Hi, On 18/04/2019 22.43, Stephen Checkoway wrote: [...] > I'm new to contributing to QEMU and I have a two procedural questions: > > 1. When should I send version 4 of this patch series? I don't want to bombard > everyone with another 11 emails after fixing every review comment, but I also > don't want to let the patch linger without addressing comments.
There is no hard rule ... I normally wait for a day or two before sending another iteration, to see whether there are any further comments. > 2. I'm not familiar with the "Acked-by" convention. I read > <https://www.kernel.org/doc/html/v4.16/process/submitting-patches.html#when-to-use-acked-by-and-cc>. > Am I supposed to add those to the commit messages or do those get added by > whomever actually includes the patch in the main QEMU repo? I assume that the patches will go in via the block tree (or another one), so I used Acked-by here to say that I've seen the patches and I'm basically fine with them from the qtests perspective (since I'm listed as qtests maintainer). When you send another iteration, you should add the "Acked-by" lines on your own, so that the information does not get lost in v4. (But when you sent the final iteration, and there are more Acked-by/Reviewed-by reply mails to that series, it's up to the maintainers to pick up these lines when including the patches to their tree.) Thomas
