Hi Alex, Thank you for your comments I will add a cover-letter and update it with the review changes, as for what I'm was hoping to add later on is mostly custom query commands for KVM perhaps might apply to other architectures as well here are things i had mind: 1. Get VM nested state, this way you can get the correct VMCS12 if we are in nested state 2. Read/Write MSR 3. Read/Write Control Registers 4. Read/Write physical memory 5. Search pattern in Physical memory
I did notice there are few custom things already in gdbstub one in particular that I would have considered that needs to modified a bit in order to be easier to parse is the 'F' command which is currently used only for ARM to syscall cb, but that's a different topic Thanks, -- Jon. On Thu, Apr 25, 2019 at 6:00 PM Alex Bennée <alex.ben...@linaro.org> wrote: > > > ari...@gmail.com writes: > > > From: Jon Doron <ari...@gmail.com> > > > > Signed-off-by: Jon Doron <ari...@gmail.com> > > Multi-patch series should have a cover letter: > > > https://wiki.qemu.org/index.php/Contribute/SubmitAPatch#Include_a_meaningful_cover_letter > > Overall this looks like a nice improvement to the parsing code. Please > CC me on the next revision. > > I'm still curious as to what additional commands you plan to implement > once this is merged? > > -- > Alex Bennée