On 22/04/19 18:09, Philippe Mathieu-Daudé wrote: > Oops... I'm surprised no compiler warned about this yet... > > This probably mean: > - This code is not covered by Continuous Integration > - Upstream maintainers are not building this code > - Upstream is not running this code > > Please tell me I'm wrong!
Indeed I am not building or running this code since it requires a Mac. I am thinking of adding a Patchew builder on macincloud, but I haven't done it yet. However, it is unlikely to be signaled by a compiler---maybe by Coverity. Probably the return value doesn't mean much to the rest of the code, the "cpu->halted = 1" is what counts. I have queued the patch. Paolo
