On 5/14/19 8:03 PM, Markus Armbruster wrote: > vubr_set_host() passes char values to isdigit(). Undefined behavior
"happens"? > when the value is negative. > > Fix by using qemu_isdigit() instead. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > tests/vhost-user-bridge.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c > index 0033b61f2e..d70b107ebc 100644 > --- a/tests/vhost-user-bridge.c > +++ b/tests/vhost-user-bridge.c > @@ -645,7 +645,7 @@ vubr_host_notifier_setup(VubrDev *dev) > static void > vubr_set_host(struct sockaddr_in *saddr, const char *host) > { > - if (isdigit(host[0])) { > + if (qemu_isdigit(host[0])) { > if (!inet_aton(host, &saddr->sin_addr)) { > fprintf(stderr, "inet_aton() failed.\n"); > exit(1); > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>