On 2011-04-21 16:10, Yaniv Kaul wrote: > Fedora 15beta/x64, latest git: > [ykaul@ykaul qemu]$ make > CC x86_64-softmmu/kvm.o > /home/ykaul/qemu/target-i386/kvm.c: In function ‘kvm_get_xsave’: > /home/ykaul/qemu/target-i386/kvm.c:953:29: error: variable ‘fop’ set but > not used [-Werror=unused-but-set-variable] > cc1: all warnings being treated as errors > > make[1]: *** [kvm.o] Error 1 > make: *** [subdir-x86_64-softmmu] Error 2 >
This one looks a bit suspicious: Avi, why do we have kvm_fpu::last_* in the ABI, copying that information from/to user land, but do not handle it otherwise? To my understanding this fop here in xsave corresponds to kvm_fpu::last_opcode in the SET/GET_FPU case, right? It's set to 0 on SET_XSAVE and ignored on GET_XSAVE as this warnings tells us. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux
