Ok, I’ll resubmit this patch series in v3, as well as v2 for SeaBIOS soon enough.
* Change “bootdevices” to “bios-geometry”, and remove the struct size * Add cpu_to_le32 fix as Laszlo suggested or big endian hosts * Fix last qtest commit - automatic docker tester for some reason does not have qemu-img set Sam > On 17 Jun 2019, at 11:38, Gerd Hoffmann <kra...@redhat.com> wrote: > > Hi, > >> Keep it extendible for a low price of ABI + “bootdevices” name. >> Or go strict and rename to “bios-geometries”? > > The name should reflect what is in there, so "bios-geometries" looks > better to me. I'd also keep it strict, unless we have at least a vague > idea what might be a useful future extension. I don't have any. > > cheers, > Gerd >