On 6/17/19 4:41 PM, Alex Bennée wrote: > > Philippe Mathieu-Daudé <phi...@redhat.com> writes: > >> From: Samuel Ortiz <sa...@linux.intel.com> >> >> They're not TCG specific and should be living the generic helper file >> instead. >> >> Signed-off-by: Samuel Ortiz <sa...@linux.intel.com> >> Reviewed-by: Robert Bradford <robert.bradf...@intel.com> >> [PMD: Rebased] >> Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> >> --- >> target/arm/helper.c | 214 >> +++++++++++++++++++++++++++++++++++++ > > Hmm so helper is a mix of non-TCG and TCG bits whereas helper-a64.c is > basically just TCG helpers. It makes me wonder if we are breaking a > convention here as helper.c is traditionally only TCG helpers. > > It feels like there should be different file that is unambiguously used > for both TCG and KVM based workloads where things like the cpu dump code > can live.
Good idea. What about target/arm/arch_dump.c? >> target/arm/internals.h | 8 ++ >> target/arm/translate-a64.c | 127 ---------------------- >> target/arm/translate.c | 87 --------------- >> target/arm/translate.h | 5 - >> 5 files changed, 222 insertions(+), 219 deletions(-)
