Patchew URL: https://patchew.org/QEMU/1561528815-4912-1-git-send-email-hang.y...@linux.intel.com/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 1561528815-4912-1-git-send-email-hang.y...@linux.intel.com Type: series Subject: [Qemu-devel] [PATCH] target/i386: HAX: Enable ROM/ROM device memory region support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/1561528815-4912-1-git-send-email-hang.y...@linux.intel.com -> patchew/1561528815-4912-1-git-send-email-hang.y...@linux.intel.com - [tag update] patchew/20190626024942.29758-1-ebl...@redhat.com -> patchew/20190626024942.29758-1-ebl...@redhat.com Switched to a new branch 'test' 9456e09 target/i386: HAX: Enable ROM/ROM device memory region support === OUTPUT BEGIN === ERROR: braces {} are necessary for all arms of this statement #32: FILE: target/i386/hax-mem.c:179: + if (memory_region_is_rom(mr) || (memory_region_is_romd(mr))) [...] + else if (!memory_region_is_ram(mr)) [...] ERROR: code indent should never use tabs #33: FILE: target/i386/hax-mem.c:180: +^Iflags |= HAX_RAM_INFO_ROM;$ ERROR: braces {} are necessary for all arms of this statement #34: FILE: target/i386/hax-mem.c:181: + else if (!memory_region_is_ram(mr)) [...] total: 3 errors, 0 warnings, 19 lines checked Commit 9456e095fae9 (target/i386: HAX: Enable ROM/ROM device memory region support) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1561528815-4912-1-git-send-email-hang.y...@linux.intel.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
