> From: Laurent Vivier <laur...@vivier.eu> > Sent: Friday, June 28, 2019 9:21 AM > To: qemu-devel@nongnu.org; aleksandar.marko...@rt-rk.com > Cc: Aleksandar Markovic > Subject: Re: [Qemu-devel] [PATCH v13 0/5] linux-user: A set of miscellaneous > patches > > Le 27/06/2019 à 21:27, no-re...@patchew.org a écrit : > > Patchew URL: https://patchew.org/> > > QEMU/1561648298-18100-1-git-send-email-aleksandar.marko...@rt-rk.com/ > > CC i386-linux-user/linux-user/uname.o > > CCAS i386-linux-user/linux-user/safe-syscall.o > > CC i386-linux-user/linux-user/i386/signal.o > > /var/tmp/patchew-tester-tmp-zqhqa95y/src/linux-user/syscall.c:323:16: > > error: > conflicting types for ‘statx’ > > 323 | _syscall5(int, statx, int, dirfd, const char *, pathname, int, > > flags, > > | ^~~~~ > > /var/tmp/patchew-tester-tmp-zqhqa95y/src/linux-user/syscall.c:214:13: note: > > in > definition of macro ‘_syscall5’ > > > > This is a real error. To avoid this you can rename it to "sys_statx" > (see sys_gettid() for instance). >
Ok, Laurent. But the root cause is a little deeper, I would say - the error appears because <sys/stat.h> is superfluously included, and glibc defines statx() basically in that header (in fact, in a headed that is always included by stat.h) - hence the error, I guess only for build systems with glibc >= 2.28. I am going to remove #include <sys/stat.h> too from the patch, is that OK, in your opinion? (and, honestly, I am almost positive this line removal is sufficient for removing build error without any name changes etc.) Yours, Aleksandar > Thanks, > Laurent
