Patchew URL: https://patchew.org/QEMU/20190702150545.1872-1-laur...@vivier.eu/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PULL 0/6] Linux user for 4.1 patches Message-id: 20190702150545.1872-1-laur...@vivier.eu === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu - [tag update] patchew/20190702150545.1872-1-laur...@vivier.eu -> patchew/20190702150545.1872-1-laur...@vivier.eu Switched to a new branch 'test' 6ca27cd linux-user: move QEMU_IFLA_BR_MULTI_BOOLOPT to the good function 21d24ae linux-user: Handle EXCP_FPE properly for MIPS 9df54dc linux-user: Introduce TARGET_HAVE_ARCH_STRUCT_FLOCK f0d89f8 linux-user: Fix target_flock structure for MIPS O64 ABI 870b610 linux-user: Add support for strace for statx() syscall 4244fb0 linux-user: Add support for translation of statx() syscall === OUTPUT BEGIN === 1/6 Checking commit 4244fb06bed0 (linux-user: Add support for translation of statx() syscall) WARNING: architecture specific defines should be avoided #63: FILE: linux-user/syscall.c:323: +#if defined(TARGET_NR_statx) && defined(__NR_statx) WARNING: architecture specific defines should be avoided #75: FILE: linux-user/syscall.c:6528: +#if defined(TARGET_NR_statx) && defined(__NR_statx) WARNING: architecture specific defines should be avoided #145: FILE: linux-user/syscall.c:10238: +#if defined(__NR_statx) total: 0 errors, 3 warnings, 186 lines checked Patch 1/6 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/6 Checking commit 870b61027feb (linux-user: Add support for strace for statx() syscall) ERROR: storage class should be at the beginning of the declaration #29: FILE: linux-user/strace.c:979: +UNUSED static struct flags statx_flags[] = { ERROR: storage class should be at the beginning of the declaration #51: FILE: linux-user/strace.c:1001: +UNUSED static struct flags statx_mask[] = { total: 2 errors, 0 warnings, 104 lines checked Patch 2/6 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/6 Checking commit f0d89f86f544 (linux-user: Fix target_flock structure for MIPS O64 ABI) 4/6 Checking commit 9df54dc293e3 (linux-user: Introduce TARGET_HAVE_ARCH_STRUCT_FLOCK) 5/6 Checking commit 21d24ae97f3e (linux-user: Handle EXCP_FPE properly for MIPS) 6/6 Checking commit 6ca27cdda6df (linux-user: move QEMU_IFLA_BR_MULTI_BOOLOPT to the good function) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190702150545.1872-1-laur...@vivier.eu/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com