On 7/12/19 1:37 PM, Aleksandar Markovic wrote: > From: Aleksandar Markovic <amarko...@wavecomp.com> > > This was found by GCC 8.3 static analysis. >
Again, please amend: Fixes: ead9360e2fb Reported-by: Stefan Weil <s...@weilnetz.de> > Signed-off-by: Aleksandar Markovic <amarko...@wavecomp.com> > --- > target/mips/translate.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/target/mips/translate.c b/target/mips/translate.c > index 59d4acd..b1cf5f0 100644 > --- a/target/mips/translate.c > +++ b/target/mips/translate.c > @@ -9826,6 +9826,7 @@ static void gen_mftr(CPUMIPSState *env, DisasContext > *ctx, int rt, int rd, > gen_mfc0(ctx, t0, rt, sel); > break; > } > + break; > case 12: > switch (sel) { > case 0: > @@ -9835,6 +9836,7 @@ static void gen_mftr(CPUMIPSState *env, DisasContext > *ctx, int rt, int rd, > gen_mfc0(ctx, t0, rt, sel); > break; > } > + break; > case 13: > switch (sel) { > case 0: > 12 years missing... Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> Tested-by: Philippe Mathieu-Daudé <phi...@redhat.com>