Am 09.07.2019 um 10:25 schrieb Peter Maydell: > On Mon, 8 Jul 2019 at 20:39, Aleksandar Markovic <amarko...@wavecomp.com> > wrote: >> They are all real issues. Two of them are cases of missing >> '/* fall through */' (I plan to send fixes for them in 4.2 timeframe) >> and five of them are cases of missing 'break' (I plan to send >> corresponding fixes for 4.1 in few days). > Adding missing /* fall through */ comments would be fine as > a patch for 4.1 rc1 if you liked, though you can of course > wait til 4.2 if that's better for you. > > thanks > -- PMM
Peter, is this fall through for ARM correct? https://github.com/qemu/qemu/blob/master/target/arm/helper.c#L7958 It looks rather suspicious and is one of the remaining related compiler warnings. Regards Stefan
