On 7/23/19 6:12 AM, Thomas Huth wrote: > The 'seq' command is not available by default on OpenBSD, so these > iotests are currently failing there. It could be installed as 'gseq' > from the coreutils package - but since it is using a different name > there and we are running the iotests with the "bash" shell anyway, > let's simply use the built-in double parentheses for the for-loops > instead. > > Signed-off-by: Thomas Huth <th...@redhat.com> > --- > tests/qemu-iotests/007 | 2 +- > tests/qemu-iotests/011 | 2 +- > tests/qemu-iotests/032 | 2 +- > tests/qemu-iotests/035 | 2 +- > tests/qemu-iotests/037 | 2 +- > tests/qemu-iotests/046 | 2 +- > tests/qemu-iotests/common.pattern | 4 ++-- > 7 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/tests/qemu-iotests/007 b/tests/qemu-iotests/007 > index 6abd402423..7d3544b479 100755 > --- a/tests/qemu-iotests/007 > +++ b/tests/qemu-iotests/007 > @@ -48,7 +48,7 @@ echo > echo "creating image" > _make_test_img 1M > > -for i in `seq 1 10`; do > +for ((i=1;i<=10;i++)); do
Stylistically, I would have preferred spaces after the ';'. But that's not a show-stopper. Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
