Daniel P. Berrangé <berra...@redhat.com> writes:
> On Sat, Jul 27, 2019 at 07:20:15PM +0100, Peter Maydell wrote: >> On Sat, 27 Jul 2019 at 13:24, Paolo Bonzini <pbonz...@redhat.com> wrote: >> > >> > On 27/07/19 09:16, Markus Armbruster wrote: >> > > We started with a single trace-events. That wasn't good, so we split it >> > > up into one per directory. That isn't good, so what about splitting it >> > > up into one per source file? Pass -DTRACE_HEADER='"trace-DIR-FOO.h" >> > > instead of -DTRACE_HEADER='"trace-DIR.h"' when compiling DIR/FOO.c. >> > >> > For Make this would all work great, however not for Meson because it >> > doesn't allow per-file compile flags. >> >> Apologies for randomly parachuting into this email thread, but if >> Meson doesn't support per-file compile flags then what's the plan >> for handling the cases where we currently need per-file compile flags ? > > I'd suggest we don't actually /need/ per-file compiler flags in most > cases. eg when we add $foo.o-libs += $(FOO_LIBS) that's not really > a per-file setting when it gets expanded onto the final linker line. > Its just a "-lfoo" that gets used for the library as a while. We do for tests, often to select a specific processor type or feature we need to build that particular instance of the test. -- Alex Bennée
