On 7/31/19 9:06 AM, Alex Bennée wrote: > +uint64_t qemu_plugin_hwaddr_to_raddr(const struct qemu_plugin_hwaddr *haddr) > +{ > +#if 0 /* XXX FIXME should be SOFTMMU */ > + ram_addr_t ram_addr; > + > + g_assert(haddr); > + ram_addr = qemu_ram_addr_from_host(haddr); > + if (ram_addr == RAM_ADDR_INVALID) { > + error_report("Bad ram pointer %p", haddr); > + abort(); > + } > + return ram_addr; > +#else > + return 0; > +#endif > +}
What would a plugin do with an raddr? This seems like a qemu internal thing, and not really related to anything that the plugin could match up to the hw. Otherwise, Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~