Markus Armbruster <arm...@redhat.com> writes:
> Alex Bennée <alex.ben...@linaro.org> writes: > >> Markus Armbruster <arm...@redhat.com> writes: >> >>> In my "build everything" tree, changing sysemu/sysemu.h triggers a >>> recompile of some 1800 out of 6600 objects (not counting tests and >>> objects that don't depend on qemu/osdep.h, down from 5400 due to the >>> previous commit). >>> >>> Several headers include sysemu/sysemu.h just to get typedef >>> VMChangeStateEntry. Move it from sysemu/sysemu.h to qemu/typedefs.h. >>> Spell its structure tag the same while there. Drop the now >>> superfluous includes of sysemu/sysemu.h from headers. >> >> You should probably mention you also fix the struct definition to meet >> our coding style. Otherwise: > > I did: "Spell its structure tag the same while there." Would you like > to suggest a better wording? Apologies - my eyes obviously glazed over that part... > >> Reviewed-by: Alex Bennée <alex.ben...@linaro.org> > > Thanks! -- Alex Bennée
