On 8/13/19 5:20 PM, Eric Blake wrote: > On 8/13/19 4:30 AM, Thomas Huth wrote: >> No test is using hmp() anymore, and since this function uses the disliked >> global_qtest variable, we should also make sure that nobody adds new code >> with this function again. qtest_hmp() should be used instead. >> >> Signed-off-by: Thomas Huth <th...@redhat.com> >> --- >> tests/libqtest.c | 11 ----------- >> tests/libqtest.h | 10 ---------- >> 2 files changed, 21 deletions(-) > > Yay. > > We could, at a later time, introduce a patch to do s/qtest_hmp/hmp/ if > it was deemed worthwhile, but I'm not sure it's worth the churn.
Actually, I like the qtest_* prefix for the libqtest functions - so it is clear at the first sight that a function is part of libqtest or rather the test itself. > Reviewed-by: Eric Blake <ebl...@redhat.com> Thanks a lot! Thomas
signature.asc
Description: OpenPGP digital signature
