On 7/19/19 12:30 PM, Andrey Shinkevich wrote:
> The new function _casenotrun() is to be invoked if a test case cannot
> be run for some reason. The user will be notified by a message passed
> to the function.
>
Oh, I assume this is a sub-test granularity; if we need to skip
individual items.
I'm good with this, but we should CC Cleber Rosa, who has struggled
against this in the past, too.
> Suggested-by: Kevin Wolf <kw...@redhat.com>
> Signed-off-by: Andrey Shinkevich <andrey.shinkev...@virtuozzo.com>
> ---
> tests/qemu-iotests/common.rc | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
> index 6e461a1..1089050 100644
> --- a/tests/qemu-iotests/common.rc
> +++ b/tests/qemu-iotests/common.rc
> @@ -428,6 +428,13 @@ _notrun()
> exit
> }
>
> +# bail out, setting up .casenotrun file
> +#
> +_casenotrun()
> +{
> + echo " [case not run] $*" >>"$OUTPUT_DIR/$seq.casenotrun"
> +}
> +
> # just plain bail out
> #
> _fail()
>
seems fine to me otherwise.
Reviewed-by: John Snow <js...@redhat.com>
