Glauber Costa <glom...@redhat.com> writes: > qdev_try_create will cope well with a NULL bus, since it will assume > the main system bus by default. qdev_create, however, wants to print > a message, in which it instantiates the bus name. That simple and at > first inoffensive message will generate a segmentation found if the > reason for failure is a NULL bus. > > I propose we avoid that - thus generating the normal hw_error by > always passing a valid bus to qdev_try_create - if none, be it the > main system bus. > > The code for testing a NULL bus is not remove from qdev_try_create > because it is a externally visible function, and we want it to continue > working fine. > > Signed-off-by: Glauber Costa <glom...@redhat.com>
"NULL means implicit main system bus" is too clever. See also commit ec990eb6. Beyond the scope of your simple fix, so: Reviewed-by: Markus Armbruster <arm...@redhat.com>
