On Fri, Aug 16, 2019 at 08:10:20AM +0200, Markus Armbruster wrote: > Eduardo Habkost <ehabk...@redhat.com> writes: > > > We have this issue reported when using libvirt to hotplug CPUs: > > https://bugzilla.redhat.com/show_bug.cgi?id=1741451 > > > > Basically, libvirt is not copying die-id from > > query-hotpluggable-cpus, but die-id is now mandatory. > > Uh-oh, "is now mandatory": making an optional property mandatory is an > incompatible change. When did we do that? Commit hash, please.
Sorry, forgot to include a "Fixes:" line. commit 176d2cda0dee9f4f78f604ad72d6a111e8e38f3b Author: Like Xu <like...@linux.intel.com> Date: Wed Jun 12 16:40:58 2019 +0800 i386/cpu: Consolidate die-id validity in smp context The field die_id (default as 0) and has_die_id are introduced to X86CPU. Following the legacy smp check rules, the die_id validity is added to the same contexts as leagcy smp variables such as hmp_hotpluggable_cpus(), machine_set_cpu_numa_node(), cpu_slot_to_string() and pc_cpu_pre_plug(). Acked-by: Dr. David Alan Gilbert <dgilb...@redhat.com> Signed-off-by: Like Xu <like...@linux.intel.com> Message-Id: <20190612084104.34984-4-like...@linux.intel.com> Reviewed-by: Eduardo Habkost <ehabk...@redhat.com> Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> -- Eduardo