On 05/17/11 06:42, David Ahern wrote: > > > On 05/17/11 01:20, Gerd Hoffmann wrote: >>> On 05/16/11 13:56, Gerd Hoffmann wrote: >>>> This patch finally merges the EHCI host adapter aka USB 2.0 support. >>>> >>>> Based on git://git.kiszka.org/qemu.git ehci >>>> >>>> Changes: >>>> - Adapt to recent changes in the usb subsystem. >>>> - Don't create device automagically, use -device instead. >>>> - Add quickstart text file, see docs/usb2.txt. >>>> - A bunch of codestyle fixups. >>>> - Add authors+contributers list. >>>> - Zap EHCI_NOMICROFRAMES, qemu can't handle a 8 kHz >>>> wakeup rate anyway. >>>> - A few bug fixes. >>>> >>>> Signed-off-by: Gerd Hoffmann<kra...@redhat.com> >>> >>> As someone who spent a significant amount of time working on the EHCI >>> code last year I am absolutely not ok with this. The entire contribution >>> history for EHCI lost - and for no reason. >> >> There is a reason. I've tried to keep the history, but it was a big >> mess with conflicts and build errors due to ehci being out-of-tree for a >> loooooong time. > > Not true. Back in March it took me less 2-1/2 hours to see a request for > a 0.14 version, update my git repo, merge master onto ehci, fix merges, > test and send out: > > http://comments.gmane.org/gmane.comp.emulators.kvm.devel/68898 > > Again, most of the changes are to the EHCI code. The rest are > sprinklings to add the adapter and adhere to USB API. > >> >>> The inclusion of EHCI into >>> qemu can be done in such a way as to maintain the history. >> >> Prove it. Give me a git tree with ehci history I can use as replacement >> for patch 18 and I'll pull it in. > > Jan's tree that was started for the EHCI development. That's my repo > locally is based on. You chose to not work with it or even get a pull > request to pull in the patches. Instead you opted to pick up the code > and plop into your repo. > > David
Let me turn this around. Your contributions to the EHCI code: 1. coding standards, 2. internal qemu API 3. nuking code based on 8kHz. All of those could have been done in Jan's tree and from there have a Jan do a pull request to the maintainers. It is not hard. (And by the way, where are the focused patches for each, especially the last one - nuking the 8kHz code? We know that it worked on linux and that printers, scanners and storage devices worked ok (mostly). Changes made in a vacuum despite prior patches and interest from qemu users - some of whom are using the EHCI code.) David > >> >> cheers, >> Gerd > >
