On Fri, Aug 02, 2019 at 05:35:58PM +0200, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <[email protected]>
>
> Add 15 new tests cases. They all rely on simple commands used for
> detecting hardware configuration information.
>
> Signed-off-by: Aleksandar Markovic <[email protected]>
> ---
> tests/acceptance/linux_ssh_mips_malta.py | 45
> ++++++++++++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
>
> diff --git a/tests/acceptance/linux_ssh_mips_malta.py
> b/tests/acceptance/linux_ssh_mips_malta.py
> index 8368e1f..c153c41 100644
> --- a/tests/acceptance/linux_ssh_mips_malta.py
> +++ b/tests/acceptance/linux_ssh_mips_malta.py
> @@ -155,6 +155,51 @@ class LinuxSSH(Test):
>
> def run_common_commands(self):
> self.ssh_command_output_contains(
> + 'cat /proc/cpuinfo',
> + '24Kc')
> + self.ssh_command_output_contains(
> + 'uname -m',
> + 'mips')
> + self.ssh_command_output_contains(
> + 'uname -r',
> + '3.2.0-4-4kc-malta')
> + self.ssh_command_output_contains(
> + 'cat /proc/interrupts',
> + 'timer')
> + self.ssh_command_output_contains(
> + 'cat /proc/interrupts',
> + 'i8042')
> + self.ssh_command_output_contains(
> + 'cat /proc/interrupts',
> + 'serial')
> + self.ssh_command_output_contains(
> + 'cat /proc/interrupts',
> + 'ata_piix')
> + self.ssh_command_output_contains(
> + 'cat /proc/interrupts',
> + 'eth0')
> + self.ssh_command_output_contains(
> + 'cat /proc/interrupts',
> + 'eth0')
> + self.ssh_command_output_contains(
> + 'cat /proc/devices',
> + 'input')
> + self.ssh_command_output_contains(
> + 'cat /proc/devices',
> + 'usb')
> + self.ssh_command_output_contains(
> + 'cat /proc/devices',
> + 'fb')
> + self.ssh_command_output_contains(
> + 'cat /proc/ioports',
> + 'serial')
> + self.ssh_command_output_contains(
> + 'cat /proc/ioports',
> + 'ata_piix')
> + self.ssh_command_output_contains(
> + 'cat /proc/ioports',
> + 'piix4_smbus')
> + self.ssh_command_output_contains(
> 'lspci -d 11ab:4620',
> 'GT-64120')
> self.ssh_command_output_contains(
> --
> 2.7.4
>
>
This is fine, although using a loop would probably result in better
readability. Something like:
for cmd, exp in [('cat /proc/cpuinfo', '24Kc'),
('uname -m', 'mips'),
...]
self.ssh_command_output_contains(cmd, exp)
Either way:
Reviewed-by: Cleber Rosa <[email protected]>
