On Wed, Sep 04, 2019 at 03:00:41PM +0200, Thomas Huth wrote: > global_qtest and the related wrapper functions often caused trouble in > the past - if they are used somewhere in the libqtest or libqos library > code, it's hard to write tests that properly track multiple test states > (like migration tests). > > This patch series finally gets rid of the remaining global_qtest > dependencies in the core libqtest code. The first patches are used to > clean up some files that should not use global_qtest anymore, then the > wrapper functions and the global_qtest definition get moved to a separate > header file called libqtest-single.h - which then should only be used in > tests that track only a single test state. > > v2: > - Do not add parameter to qvirtio_wait_config_isr(), but push the logic > into virtio-mmio.c and virtio-pci.c instead since we have access to > the test state here (as suggested by Laurent).
Looks good overall. I posted one comment on a patch. Stefan
signature.asc
Description: PGP signature
