On Tue, 3 Sep 2019 at 09:40, Auger Eric <eric.au...@redhat.com> wrote: > I guess arm_cpu_kvm_set_irq attempting to inject IRQ/FIQ into KVM is > used with userspace GIC emulation, which is not supported along with > GICv3. But anyway, I guess it does not hurt to set vcpu_index2 in > arm_cpu_kvm_set_irq?
Having now got up to speed with the kernel patchset that goes with this one: yes, we should set the vcpu_index2 in the arm_cpu_kvm_set_irq function as well. Given that we have two callsites that now need to assemble the value for kvm_set_irq() and the cpu_index field is in two pieces, maybe we should define a utility function that takes cpu-index, irq-type and irq-id as separate arguments and assembles the fields into the right places and calls kvm_set_irq() ? thanks -- PMM
