On Mon, 9 Sep 2019 at 17:05, Laurent Vivier <laur...@vivier.eu> wrote: > > Co-developed-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> > Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> > Signed-off-by: Laurent Vivier <laur...@vivier.eu> > Reviewed-by: Hervé Poussineau <hpous...@reactos.org>
> +static void sysbus_swim_class_init(ObjectClass *oc, void *data) > +{ > + DeviceClass *dc = DEVICE_CLASS(oc); > + > + dc->realize = sysbus_swim_realize; > +} Missing reset and VMState for migration. These should be baseline requirements for adding new device models to the tree, because in an ideal world every device would support both -- we should be gradually fixing the existing devices which are missing these, and not letting new devices in, so the situation gets gradually better, not worse. thanks -- PMM