On Mon, Sep 16, 2019 at 09:23:47AM -0400, Igor Mammedov wrote: > PS: > I don't have access to a suitable system to test it.
Hmm I feel like it would be good to have series like this to be at least smoke tested somehow... How about manually setup a very small max memslot size and test it on x86? IMHO we'd test with both KVMState.manual_dirty_log_protect to be on & off to make sure to cover the log_clear() code path. And of course to trigger those paths we probably need migrations, but I believe local migrations would be enough. And since at it, I'm thinking whether we should start assert() in some way in memory_region_allocate_system_memory() to make sure it's not called twice from now on on any board. Regards, -- Peter Xu
