On Tue, 17 Sep 2019 at 16:11, Michael S. Tsirkin <m...@redhat.com> wrote: > > On Wed, Sep 11, 2019 at 09:55:34AM -0400, Michael S. Tsirkin wrote: > > On Wed, Sep 11, 2019 at 03:50:15PM +0200, Igor Mammedov wrote: > > > On Wed, 11 Sep 2019 13:57:06 +0100 > > > Peter Maydell <peter.mayd...@linaro.org> wrote: > > > > Do the tests pass with this patch and without the > > > > patch that adds the tests? (That is, can we keep the > > > > two patches separate without breaking bisection, or > > > > do we need to squash them together?) > > > > > > > > I'll leave it to somebody who understands the ACPI > > > > tests stuff to answer whether there's a better way to > > > I'd squash this patch into 11/11 test case, > > > > > > Pls don't - the way to add this is to add the files in question to > > tests/bios-tables-test-allowed-diff.h. > > > > Maintainer will create a separate commit updating > > the binaries and removing them from the whitelist.
Who is "maintainer" in this part of the process? Why can't the submitter just create the patches and send them? > > This way things like rebase work seemlessly. > > > OK? > > Can you post v11 like this? I'll ack then. thanks -- PMM
