John Snow <js...@redhat.com> writes:
> On 9/17/19 2:58 PM, Alex Bennée wrote:
>>
>> John Snow <js...@redhat.com> writes:
>>
>>> It's not used; so remove the distraction.
>>
>> It's a developer feature so you can run specific builds against the VM
>> images. I certainly have used it, unless you are saying it's broken now?
>>
>
> What consumes it? I can't find where it *does* something:
It's past as the rest:
-- \ <- all args after this
$(if $(TARGET_LIST),--target-list=$(TARGET_LIST)) \
$(if $(EXTRA_CONFIGURE_OPTS),$(EXTRA_CONFIGURE_OPTS)), \
Become argv in:
args, argv = parse_args(vmcls)
...
cmd = [vm.BUILD_SCRIPT.format(
configure_opts = " ".join(argv),
jobs=int(args.jobs),
target=args.build_target,
verbose = "V=1" if args.verbose else "")]
>
> jhuston@probe ~/s/q/t/vm (docker-partial-fixup)> git grep TARGET_LIST
> Makefile.include: @echo " TARGET_LIST=a,b,c -
> Override target list in builds"
> Makefile.include: $(if
> $(TARGET_LIST),--target-list=$(TARGET_LIST)) \
> jhuston@probe ~/s/q/t/vm (docker-partial-fixup)> git grep target-list
> Makefile.include: $(if
> $(TARGET_LIST),--target-list=$(TARGET_LIST)) \
> jhuston@probe ~/s/q/t/vm (docker-partial-fixup)> git grep target_list
> jhuston@probe ~/s/q/t/vm (docker-partial-fixup) [1]>
>
>
> the VM script doesn't seem to pick it up or apply defaults, so I don't
> know where this was supposed to be routed to.
>
>
>>>
>>> Signed-off-by: John Snow <js...@redhat.com>
>>> ---
>>> tests/vm/Makefile.include | 2 --
>>> 1 file changed, 2 deletions(-)
>>>
>>> diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include
>>> index fea348e845..61758101fa 100644
>>> --- a/tests/vm/Makefile.include
>>> +++ b/tests/vm/Makefile.include
>>> @@ -28,7 +28,6 @@ vm-help vm-test:
>>> @echo
>>> @echo "Special variables:"
>>> @echo " BUILD_TARGET=foo - Override the build target"
>>> - @echo " TARGET_LIST=a,b,c - Override target list in
>>> builds"
>>> @echo ' EXTRA_CONFIGURE_OPTS="..."'
>>> @echo " J=[0..9]* - Override the -jN parameter
>>> for make commands"
>>> @echo " DEBUG=1 - Enable verbose output on
>>> host and interactive debugging"
>>> @@ -65,7 +64,6 @@ vm-build-%: $(IMAGES_DIR)/%.img
>>> $(if $(BUILD_TARGET),--build-target $(BUILD_TARGET)) \
>>> --snapshot \
>>> --build-qemu $(SRC_PATH) -- \
>>> - $(if $(TARGET_LIST),--target-list=$(TARGET_LIST)) \
>>> $(if $(EXTRA_CONFIGURE_OPTS),$(EXTRA_CONFIGURE_OPTS)), \
>>> " VM-BUILD $*")
>>
>>
--
Alex Bennée
