On 19/09/19 23:39, miny...@acm.org wrote: > I haven't gotten a lot of commentary on this, but I assume that means > that everything is ok. It's been posted a few times and the last time > I received no issues, just a couple of reviews. I would like more > review. But I'm not quite sure what to do about that, I've been > hanging on to these changes far too long.
It's just that not many people here are IPMI-savvy. I took a quick look at patches 5 and 15, and they look fine. Paolo > The following changes since commit a77d20bafcd4cb7684168a9b4c6dc2a321aaeb50: > > Merge remote-tracking branch 'remotes/kraxel/tags/ui-20190919-pull-request' > into staging (2019-09-19 17:16:07 +0100) > > are available in the Git repository at: > > https://github.com/cminyard/qemu.git tags/ipmi-for-release-2019-09-19 > > for you to fetch changes up to d9b74295c6528fd68cebdea116b283e46543b2a2: > > pc: Add an SMB0 ACPI device to q35 (2019-09-19 14:41:58 -0500) > > ---------------------------------------------------------------- > ipmi: Some bug fixes and new interfaces > > Some bug fixes for the watchdog and hopeful the BT tests. > > Change the IPMI UUID handling to give the user the ability to set it or > not have it. > > Add a PCI interface. > > Add an SMBus interfaces. > > -corey > > ---------------------------------------------------------------- > Corey Minyard (15): > ipmi: Fix watchdog NMI handling > ipmi: Fix the get watchdog command > ipmi: Generate an interrupt on watchdog pretimeout expiry > tests:ipmi: Fix IPMI BT tests > qdev: Add a no default uuid property > ipmi: Add a UUID device property > ipmi: Split out KCS-specific code from ISA KCS code > ipmi: Split out BT-specific code from ISA BT code > ipmi: Allow a size value to be passed for I/O space > smbios:ipmi: Ignore IPMI devices with no fwinfo function > ipmi: Add PCI IPMI interfaces > ipmi: Add an SMBus IPMI interface > acpi: Add i2c serial bus CRS handling > ipmi: Fix SSIF ACPI handling to use the right CRS > pc: Add an SMB0 ACPI device to q35 > > default-configs/i386-softmmu.mak | 3 + > hw/acpi/aml-build.c | 40 ++++ > hw/acpi/ipmi-stub.c | 2 +- > hw/acpi/ipmi.c | 13 +- > hw/i386/Kconfig | 3 + > hw/i386/acpi-build.c | 17 +- > hw/i386/pc_piix.c | 12 +- > hw/i386/pc_q35.c | 9 +- > hw/ipmi/Kconfig | 15 ++ > hw/ipmi/Makefile.objs | 5 +- > hw/ipmi/ipmi.c | 6 +- > hw/ipmi/ipmi_bmc_sim.c | 30 ++- > hw/ipmi/ipmi_bt.c | 437 ++++++++++++++++++++++++++++++++++++++ > hw/ipmi/ipmi_kcs.c | 423 +++++++++++++++++++++++++++++++++++++ > hw/ipmi/isa_ipmi_bt.c | 443 > ++------------------------------------- > hw/ipmi/isa_ipmi_kcs.c | 419 ++---------------------------------- > hw/ipmi/pci_ipmi_bt.c | 146 +++++++++++++ > hw/ipmi/pci_ipmi_kcs.c | 146 +++++++++++++ > hw/ipmi/smbus_ipmi.c | 384 +++++++++++++++++++++++++++++++++ > hw/smbios/smbios_type_38.c | 3 + > include/hw/acpi/aml-build.h | 18 ++ > include/hw/acpi/ipmi.h | 2 +- > include/hw/i386/pc.h | 2 + > include/hw/ipmi/ipmi.h | 7 +- > include/hw/ipmi/ipmi_bt.h | 73 +++++++ > include/hw/ipmi/ipmi_kcs.h | 76 +++++++ > include/hw/pci/pci.h | 1 + > include/hw/qdev-properties.h | 7 + > qemu-options.hx | 10 +- > tests/Makefile.include | 3 +- > tests/data/acpi/q35/DSDT | Bin 7841 -> 7879 bytes > tests/data/acpi/q35/DSDT.bridge | Bin 7858 -> 7896 bytes > tests/data/acpi/q35/DSDT.cphp | Bin 8304 -> 8342 bytes > tests/data/acpi/q35/DSDT.dimmpxm | Bin 9494 -> 9532 bytes > tests/data/acpi/q35/DSDT.ipmibt | Bin 7916 -> 7954 bytes > tests/data/acpi/q35/DSDT.memhp | Bin 9200 -> 9238 bytes > tests/data/acpi/q35/DSDT.mmio64 | Bin 8971 -> 9009 bytes > tests/data/acpi/q35/DSDT.numamem | Bin 7847 -> 7885 bytes > tests/ipmi-bt-test.c | 6 +- > 39 files changed, 1902 insertions(+), 859 deletions(-) > create mode 100644 hw/ipmi/ipmi_bt.c > create mode 100644 hw/ipmi/ipmi_kcs.c > create mode 100644 hw/ipmi/pci_ipmi_bt.c > create mode 100644 hw/ipmi/pci_ipmi_kcs.c > create mode 100644 hw/ipmi/smbus_ipmi.c > create mode 100644 include/hw/ipmi/ipmi_bt.h > create mode 100644 include/hw/ipmi/ipmi_kcs.h > > >
