On 9/23/19 1:26 AM, David Hildenbrand wrote: >> +void finalize_target_page_bits(void) >> +{ >> +#ifdef TARGET_PAGE_BITS_VARY >> + if (target_page_bits == 0) { >> + target_page_bits = TARGET_PAGE_BITS_MIN; >> + } >> + target_page_bits_decided = true; >> +#endif >> +} > I wonder if it would be nicer to handle this in the header file instead, > providing dummy functions there.
No can do, because set_preferred_target_page_bits is used by vl.c, which is compiled once and so does not have access to cpu.h definitions. r~