On 9/24/19 8:49 AM, Nir Soffer wrote: > On Tue, Sep 24, 2019 at 4:18 PM Eric Blake <ebl...@redhat.com> wrote: > >> Doing so catches the bugs we just fixed with NBD not properly using >> correct contexts. >> >> Signed-off-by: Eric Blake <ebl...@redhat.com> >> Message-Id: <20190920220729.31801-1-ebl...@redhat.com> >> --- >> tests/qemu-iotests/223 | 6 ++++-- >> tests/qemu-iotests/223.out | 1 + >> 2 files changed, 5 insertions(+), 2 deletions(-)
>> -_launch_qemu 2> >(_filter_nbd) >> +_launch_qemu -object iothread,id=io0 2> >(_filter_nbd) >> > > But now we will not catch bugs in flows that do not use iothreads. > > I think it will be better to run this test twice, one with iothreads, one > without. Too late for this pull request, but I will propose that as a followup patch. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
