On 05/20/2011 12:59 PM, Stefan Hajnoczi wrote:
This coroutines implementation is based on the gtk-vnc implementation
written by Anthony Liguori<anth...@codemonkey.ws>  but it has been
significantly rewritten by Kevin Wolf<kw...@redhat.com>  to use
setjmp()/longjmp() instead of the more expensive swapcontext() and by
Paolo Bonzini<pbonz...@redhat.com>  for Windows Fibers support.


Not a blocker at all, but why did you move the pooling to the ucontext implementation? It's less expensive to create the fiber in Windows because there are no system calls (unlike swapcontext), but a future pthread-based implementation will also need the pooling.

It can be left to whoever writes the pthread stuff, though.

Paolo

Reply via email to