On Thu, 26 Sep 2019 at 17:02, Philippe Mathieu-Daudé <phi...@redhat.com> wrote: > > On 9/26/19 5:17 PM, Philippe Mathieu-Daudé wrote: > > Convert the reset handler into a proper Device reset method. > > Marc-André noticed this one is incorrect, because while being QDEV it is > not connected to a QBUS. > > Maybe we can add a Device::unconnected property, and when set, the > parent realize() calls 'qemu_register_reset(dev->reset, dev);'? > This might look the same, but at least Devices implementations could > stop to use this function...
I'm not in favour of ad-hoc attempts to patch the problem with some devices not being reset like this. I'd rather we figured out a general solution to the design problem (which isn't easy, but on the other hand the set of workarounds we currently have isn't too awful to deal with). thanks -- PMM