On Fri, Sep 06, 2019 at 07:13:09PM +0000, Moger, Babu wrote: > Adds new epyc property in PCMachineState and also in MachineState. > This property will be used to initialize the mode specific handlers > to generate apic ids. > > Signed-off-by: Babu Moger <babu.mo...@amd.com> > --- [...] > diff --git a/include/hw/boards.h b/include/hw/boards.h > index 12eb5032a5..0001d42e50 100644 > --- a/include/hw/boards.h > +++ b/include/hw/boards.h > @@ -299,6 +299,8 @@ struct MachineState { > AccelState *accelerator; > CPUArchIdList *possible_cpus; > CpuTopology smp; > + bool epyc; > +
This won't scale at all when we start adding new CPU models with different topology constraints. I still have hope we can avoid having separate set of topology ID functions (see my reply to "hw/386: Add new epyc mode topology decoding functions"). But if we really have to create separate functions, we can make them part of the CPU model table, not a boolean machine property. -- Eduardo