Le 10/09/2019 à 21:34, Alex Bennée a écrit : > Most of the users of elf.h just want the standard Elf definitions. The > couple that want more than that want an expansion based on ELF_CLASS > which can be used for size agnostic code. The later is moved into > elf/elf-types.inc.h to make it clearer what it is for. While doing > that I also removed the whitespace damage. > > Signed-off-by: Alex Bennée <alex.ben...@linaro.org> > --- > bsd-user/elfload.c | 2 +- > contrib/elf2dmp/qemu_elf.h | 2 +- > disas.c | 2 +- > dump/dump.c | 2 +- > dump/win_dump.c | 2 +- > hw/alpha/dp264.c | 2 +- > hw/arm/armv7m.c | 2 +- > hw/arm/boot.c | 2 +- > hw/core/loader.c | 3 +- > hw/cris/axis_dev88.c | 2 +- > hw/cris/boot.c | 2 +- > hw/hppa/machine.c | 2 +- > hw/i386/multiboot.c | 2 +- > hw/i386/pc.c | 2 +- > hw/lm32/lm32_boards.c | 2 +- > hw/lm32/milkymist.c | 2 +- > hw/m68k/an5206.c | 2 +- > hw/m68k/mcf5208.c | 2 +- > hw/microblaze/boot.c | 2 +- > hw/mips/mips_fulong2e.c | 2 +- > hw/mips/mips_malta.c | 2 +- > hw/mips/mips_mipssim.c | 2 +- > hw/mips/mips_r4k.c | 2 +- > hw/moxie/moxiesim.c | 2 +- > hw/nios2/boot.c | 2 +- > hw/openrisc/openrisc_sim.c | 2 +- > hw/pci-host/prep.c | 2 +- > hw/ppc/e500.c | 2 +- > hw/ppc/mac_newworld.c | 2 +- > hw/ppc/mac_oldworld.c | 2 +- > hw/ppc/ppc440_bamboo.c | 2 +- > hw/ppc/prep.c | 2 +- > hw/ppc/sam460ex.c | 2 +- > hw/ppc/spapr.c | 2 +- > hw/ppc/spapr_vio.c | 2 +- > hw/ppc/virtex_ml507.c | 2 +- > hw/riscv/boot.c | 2 +- > hw/s390x/ipl.c | 2 +- > hw/sparc/leon3.c | 2 +- > hw/sparc/sun4m.c | 2 +- > hw/sparc64/sun4u.c | 2 +- > hw/tricore/tricore_testboard.c | 2 +- > hw/xtensa/sim.c | 2 +- > hw/xtensa/xtfpga.c | 2 +- > include/elf/elf-types.inc.h | 63 ++++++++++++++++++++++++++++++++ > include/{ => elf}/elf.h | 42 --------------------- > include/hw/core/generic-loader.h | 2 +- > linux-user/arm/cpu_loop.c | 2 +- > linux-user/elfload.c | 5 +-- > linux-user/main.c | 2 +- > linux-user/mips/cpu_loop.c | 2 +- > linux-user/riscv/cpu_loop.c | 2 +- > target/arm/arch_dump.c | 2 +- > target/i386/arch_dump.c | 2 +- > target/ppc/arch_dump.c | 2 +- > target/ppc/kvm.c | 2 +- > target/s390x/arch_dump.c | 2 +- > tcg/arm/tcg-target.inc.c | 2 +- > tcg/ppc/tcg-target.inc.c | 2 +- > tcg/s390/tcg-target.inc.c | 2 +- > tcg/tcg.c | 5 ++- > util/getauxval.c | 2 +- > 62 files changed, 128 insertions(+), 104 deletions(-) > create mode 100644 include/elf/elf-types.inc.h
The patch looks good, but why did you call the file "elf-types.inc.h" and not "elf-types.h"? Reviewed-by: Laurent Vivier <laur...@vivier.eu> Thanks, LAurent