Patchew URL: https://patchew.org/QEMU/1571925835-31930-1-git-send-email-pbonz...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 00/39] Misc (mostly x86) patches for 2019-10-24 Type: series Message-id: 1571925835-31930-1-git-send-email-pbonz...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 4f4f906 i386: implement IGNNE d2fd259 target/i386: introduce cpu_set_fpus 52ffa84 target/i386: move FERR handling to target/i386 6ab413e core: replace getpagesize() with qemu_real_host_page_size b11b965 audio: fix missing break 6d328cf mc146818rtc: always register rtc to rtc list 2dee65a mc146818rtc: Include mc146818rtc_regs.h directly in mc146818rtc.c 4950ef7 mc146818rtc: Move RTC_ISA_IRQ definition a020047 mc146818rtc: move structure to header file 43bb622 hw/i386/pc: Remove kvm_i386.h include 435f326 hw/i386/pc: Extract pc_i8259_create() 75cc1a0 hw/i386/pc: Move gsi_state creation code c130e98 hw/i386/pc: Extract pc_gsi_create() ed6079c target/i386: Add support for save/load IA32_UMWAIT_CONTROL MSR a1cf070 x86/cpu: Add support for UMONITOR/UMWAIT/TPAUSE 175fcf8 hw/timer/mc146818rtc: Only include qapi-commands-misc on I386 8cb9887 runstate: ignore exit request in finish migrate state ccabb3b checkpatch: suggest qemu_real_host_page_size instead of getpagesize() or sysconf(_SC_PAGESIZE) a790c48 MAINTAINERS: add microvm related files 5581800 hw/i386: Introduce the microvm machine type f069a21 docs/microvm.rst: document the new microvm machine type 12fc113 roms: add microvm-bios (qboot) as binary and git submodule 7616d00 hw/intc/apic: reject pic ints if isa_pic == NULL 7610afb fw_cfg: add "modify" functions for all types b02e61c hw/i386: make x86.c independent from PCMachineState 06ab7d0 hw/i386: split PCMachineState deriving X86MachineState from it c6d1465 hw/i386/pc: move shared x86 functions to x86.c and export them efb2fb8 hw/i386/pc: remove commented out code from x86_load_linux() 7ca3f4d hw/i386/pc: avoid an assignment in if condition in x86_load_linux() 76f87f6 hw/i386/pc: replace use of strtol with qemu_strtoui in x86_load_linux() 2b1d644 hw/i386/pc: fix code style issues on functions that will be moved out 5cf9b30 hw/i386/pc: rename functions shared with non-PC machines 342ded8 hw/virtio: Factorize virtio-mmio headers 9fcf46c memory-device: simplify Makefile.objs conditions b9e7378 Do not use %m in common code to print error messages 165f7c9 i386/kvm: add NoNonArchitecturalCoreSharing Hyper-V enlightenment 69ba817 Updated Bulgarian translation (19) - 4.1.0 5fb33e9 mc146818rtc: fix timer interrupt reinjection d56989d target/i386: log MCE guest and host addresses === OUTPUT BEGIN === 1/39 Checking commit d56989d83eb2 (target/i386: log MCE guest and host addresses) 2/39 Checking commit 5fb33e988fbe (mc146818rtc: fix timer interrupt reinjection) 3/39 Checking commit 69ba817e6717 (Updated Bulgarian translation (19) - 4.1.0) 4/39 Checking commit 165f7c93fe47 (i386/kvm: add NoNonArchitecturalCoreSharing Hyper-V enlightenment) 5/39 Checking commit b9e737803b9a (Do not use %m in common code to print error messages) 6/39 Checking commit 9fcf46c30b49 (memory-device: simplify Makefile.objs conditions) 7/39 Checking commit 342ded81f836 (hw/virtio: Factorize virtio-mmio headers) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #80: new file mode 100644 total: 0 errors, 1 warnings, 131 lines checked Patch 7/39 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/39 Checking commit 5cf9b30de456 (hw/i386/pc: rename functions shared with non-PC machines) 9/39 Checking commit 2b1d64422081 (hw/i386/pc: fix code style issues on functions that will be moved out) 10/39 Checking commit 76f87f6ca7d9 (hw/i386/pc: replace use of strtol with qemu_strtoui in x86_load_linux()) 11/39 Checking commit 7ca3f4d5c4cc (hw/i386/pc: avoid an assignment in if condition in x86_load_linux()) 12/39 Checking commit efb2fb89cbde (hw/i386/pc: remove commented out code from x86_load_linux()) 13/39 Checking commit c6d14657ad32 (hw/i386/pc: move shared x86 functions to x86.c and export them) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #767: new file mode 100644 total: 0 errors, 1 warnings, 1449 lines checked Patch 13/39 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/39 Checking commit 06ab7d08e59d (hw/i386: split PCMachineState deriving X86MachineState from it) 15/39 Checking commit b02e61c98802 (hw/i386: make x86.c independent from PCMachineState) 16/39 Checking commit 7610afb385a7 (fw_cfg: add "modify" functions for all types) 17/39 Checking commit 7616d00f9fe2 (hw/intc/apic: reject pic ints if isa_pic == NULL) 18/39 Checking commit 12fc113d9d76 (roms: add microvm-bios (qboot) as binary and git submodule) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 total: 0 errors, 1 warnings, 28 lines checked Patch 18/39 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/39 Checking commit f069a218c30a (docs/microvm.rst: document the new microvm machine type) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 total: 0 errors, 1 warnings, 108 lines checked Patch 19/39 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/39 Checking commit 5581800c1da8 (hw/i386: Introduce the microvm machine type) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #62: new file mode 100644 total: 0 errors, 1 warnings, 670 lines checked Patch 20/39 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/39 Checking commit a790c48b0f93 (MAINTAINERS: add microvm related files) 22/39 Checking commit ccabb3bb815b (checkpatch: suggest qemu_real_host_page_size instead of getpagesize() or sysconf(_SC_PAGESIZE)) ERROR: line over 90 characters #26: FILE: scripts/checkpatch.pl:2919: + ERROR("use qemu_real_host_page_size instead of getpagesize()\n" . $herecurr); ERROR: line over 90 characters #29: FILE: scripts/checkpatch.pl:2922: + ERROR("use qemu_real_host_page_size instead of sysconf(_SC_PAGESIZE)\n" . $herecurr); total: 2 errors, 0 warnings, 12 lines checked Patch 22/39 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 23/39 Checking commit 8cb98874af80 (runstate: ignore exit request in finish migrate state) 24/39 Checking commit 175fcf87450d (hw/timer/mc146818rtc: Only include qapi-commands-misc on I386) 25/39 Checking commit a1cf0708ef9d (x86/cpu: Add support for UMONITOR/UMWAIT/TPAUSE) WARNING: Block comments use a leading /* on a separate line #45: FILE: target/i386/cpu.c:1061: + NULL /* ospke */, "waitpkg", "avx512vbmi2", NULL, total: 0 errors, 1 warnings, 28 lines checked Patch 25/39 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 26/39 Checking commit ed6079c493d0 (target/i386: Add support for save/load IA32_UMWAIT_CONTROL MSR) 27/39 Checking commit c130e98ab1fd (hw/i386/pc: Extract pc_gsi_create()) 28/39 Checking commit 75cc1a087bb6 (hw/i386/pc: Move gsi_state creation code) 29/39 Checking commit 435f326bf1bd (hw/i386/pc: Extract pc_i8259_create()) 30/39 Checking commit 43bb6226ffe3 (hw/i386/pc: Remove kvm_i386.h include) 31/39 Checking commit a02004740c2b (mc146818rtc: move structure to header file) 32/39 Checking commit 4950ef7063d6 (mc146818rtc: Move RTC_ISA_IRQ definition) 33/39 Checking commit 2dee65acb4d0 (mc146818rtc: Include mc146818rtc_regs.h directly in mc146818rtc.c) 34/39 Checking commit 6d328cf20bb3 (mc146818rtc: always register rtc to rtc list) 35/39 Checking commit b11b96565a6b (audio: fix missing break) 36/39 Checking commit 6ab413ef38d9 (core: replace getpagesize() with qemu_real_host_page_size) 37/39 Checking commit 52ffa842a569 (target/i386: move FERR handling to target/i386) 38/39 Checking commit d2fd2595f5e5 (target/i386: introduce cpu_set_fpus) 39/39 Checking commit 4f4f9069846a (i386: implement IGNNE) WARNING: line over 80 characters #113: FILE: target/i386/fpu_helper.c:1074: + * Here the processor deasserts FERR#; in response, the chipset deasserts total: 0 errors, 1 warnings, 86 lines checked Patch 39/39 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1571925835-31930-1-git-send-email-pbonz...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com