On 20/11/2019 15:34, Juan Quintela wrote: > Laurent Vivier <lviv...@redhat.com> wrote: >> Commit 29cb4187497d ("spapr: Set VSMT to smp_threads by default") >> has introduced a new default value for VSMT that is not supported >> by old kernels (before 4.13 kernel) and this breaks "make check" >> on these kernels. >> >> To fix that, explicitly set in the involved tests the value that was >> used as the default value before the change. >> >> Cc: Greg Kurz <gr...@kaod.org> >> Signed-off-by: Laurent Vivier <lviv...@redhat.com> > > Reviewed-by: Juan Quintela <quint...@redhat.com> > > A comment telling that never their use could help for future readers > O:-)
I assumed that "git blame" would be enough for a reader that wants more details :) Thanks, Laurent