On Fri, 18 Oct 2019 at 16:07, Damien Hedde <damien.he...@greensocs.com> wrote: > > This commit adds support of Resettable interface to buses and devices: > + ResettableState structure is added in the Bus/Device state > + Resettable methods are implemented. > + device/bus_is_in_reset function defined > > This commit allows to transition the objects to the new > multi-phase interface without changing the reset behavior at all. > Object single reset method can be split into the 3 different phases > but the 3 phases are still executed in a row for a given object. > From the qdev/qbus reset api point of view, nothing is changed. > qdev_reset_all() and qbus_reset_all() are not modified as well as > device_legacy_reset(). > > Transition of an object must be done from mother class to daughter > classes.
The standard terminology here is "parent class" and "child class". I notice you've used mother/daughter in a bunch of other comments in various patches -- could you change that to the more usual terms, please? > Care has been taken to allow the transition of a mother class > without requiring the daughter classes to be transitioned at the same > time. Note that SysBus and SysBusDevice class do not need any transition > because they do not override the legacy reset method. > > Signed-off-by: Damien Hedde <damien.he...@greensocs.com> Otherwise Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM