On 11/30/19 8:45 AM, Alex Bennée wrote: > -static int cpu_read_virt_reg(CPUS390XState *env, uint8_t *mem_buf, int n) > +static int cpu_read_virt_reg(CPUS390XState *env, GByteArray *mem_buf, int n) > { > switch (n) { > case S390_VIRT_CKC_REGNUM: > @@ -296,9 +296,9 @@ static int cpu_write_virt_reg(CPUS390XState *env, uint8_t > *mem_buf, int n) > /* total number of registers in s390-gs.xml */ > #define S390_NUM_GS_REGS 4 > > -static int cpu_read_gs_reg(CPUS390XState *env, uint8_t *mem_buf, int n) > +static int cpu_read_gs_reg(CPUS390XState *env, GByteArray *buf, int n)
Sometimes you're changing the name from mem_buf and sometimes not. Perhaps better not to change it anywhere, or change it everywhere first, without changing the type. r~