On Sat, Nov 30, 2019 at 08:42:19PM +0100, Markus Armbruster wrote:
PATCH 2-4 fix crash bugs. Including them would be a no-brainer at
-rc0. But we're post -rc3, and even for crash bugs we require a
certain likelihood of users getting bitten.
Jens, please assess impact of PATCH 2's crash bug.
Guest can't use it to trigger a qemu crash because the hotplug_handler
called after the pre-plug doesn't do anything with errp.
qemu_opt_set_bool() is also unlikely to trigger the bug because both
reasons for why it would set errp are not true in this path.
I would prefer for this fix to go into 4.2 but if it is the only one
and triggers a large amount of work then don't do it.
regards
Jens