On Tue, 3 Dec 2019 14:33:25 +0100 Christian Borntraeger <borntrae...@de.ibm.com> wrote:
> On 03.12.19 14:28, Janosch Frank wrote: > > We need to set the short psw indication bit in the reset psw, as it is > > a short psw. > > > > fixes: 9629823290 ("pc-bios/s390-ccw: do a subsystem reset before running > > the guest") > > Signed-off-by: Janosch Frank <fran...@linux.ibm.com> > > We should also add > commit 24bb1fa36ff7b25ee774dbe4a18830dc782b54bf (HEAD, > github-cohuck/s390-next) > Author: Janosch Frank <fran...@linux.ibm.com> > AuthorDate: Fri Nov 29 09:20:23 2019 -0500 > Commit: Cornelia Huck <coh...@redhat.com> > CommitDate: Mon Dec 2 09:58:57 2019 +0100 > > s390x: Properly fetch and test the short psw on diag308 subc 0/1 > > or whatever the final commit id will be. While this patch is not "broken" > it exposes the bug. Probably better to use "Exposed by (...)", then? We'll be fine as long as we have a bios rebuilt with this fix, and anybody using the official QEMU should get that. Pointing to the commit should be enough for any backporters. > > > > > --- > > pc-bios/s390-ccw/jump2ipl.c | 12 +++++++----- > > 1 file changed, 7 insertions(+), 5 deletions(-)