05.12.2019 19:58, Eric Blake wrote: > On 12/5/19 9:20 AM, Vladimir Sementsov-Ogievskiy wrote: >> Make qbus_list_bus and qbus_list_dev hint append helpers well formed: >> rename errp to errp_in, as it is IN-parameter here (which is unusual >> for errp), rename functions to be error_append_*_hint. > > Commit message mentions a rename... > >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> >> --- >> qdev-monitor.c | 12 +++++++----- >> 1 file changed, 7 insertions(+), 5 deletions(-) >> >> diff --git a/qdev-monitor.c b/qdev-monitor.c >> index 29ed73e56a..3465a1e2d0 100644 >> --- a/qdev-monitor.c >> +++ b/qdev-monitor.c >> @@ -328,7 +328,8 @@ static Object *qdev_get_peripheral_anon(void) >> return dev; >> } >> -static void qbus_list_bus(DeviceState *dev, Error **errp) >> +static void qbus_error_append_bus_list_hint(DeviceState *dev, >> + Error *const *errp) > > ...but instead you did a type change with the name left unchanged. Commit > message needs a fix. >
Oops. I blindly take Markus's fixum, and didn't fix commit messages. I'll resend. -- Best regards, Vladimir
