On Thursday, November 14, 2019, Philippe Mathieu-Daudé <phi...@redhat.com> wrote:
> On 11/14/19 2:08 PM, chen huacai wrote: > >> Hi, all, >> >> On Thu, Nov 14, 2019 at 8:34 PM Aleksandar Markovic >> <amarko...@wavecomp.com> wrote: >> >>> >>> Hi, Philippe, >>> >>> From: Philippe Mathieu-Daudé <phi...@redhat.com> >>>> >>>> Hi Aleksandar, >>>> >>>> On 11/13/19 2:47 PM, Aleksandar Markovic wrote: >>>> >>>>> From: Aleksandar Markovic <amarko...@wavecomp.com> >>>>> >>>>> Change the maintainership for Fulong 2E board to improve its quality. >>>>> >>>> >>>> IIRC you told me once this board is named Fuloong, and its CPU is a >>>> >>> > Loongson, both with 2x 'o' :) I have a patch renaming the various >>> >>>> occurrences. >>>> >>>> >>> I still think that the oficial name is "Fuloong 2E", however, it is >>> shortened to "Fulong 2E" quite often in communication, and, it seems, >>> sometimes even in various docs/app notes etc. >>> >>> Can perhaps Huacai Chen enlighten us regarding the right spelling? >>> >> The right spelling is Fuloong. >> >> [...]>>> The original author is active on the Linux kernel, let ask him > if he'd > >> be OK to keep an eye on his work. >>>> >>>> Huacai, would you agree to be listed as a reviewer on the Fuloong >>>> related QEMU files? You don't have to worry about the generic QEMU code >>>> plate (like keeping API up to date) I'll manage that, but I'd like to >>>> have you listed to assert the hardware is properly modeled. >>>> >>>> You would appear as: >>>> R: Huacai Chen <che...@lemote.com> >>>> >>>> >>> That is a great idea! >>> >>> Please, Chen, get involved, you would be very welcomed, there is a place >>> for you in QEMU community! >>> >> I'm sorry that I'm busy now, but I think I will do something in QEMU >> in the next year. >> > > No problem, we'll keep in touch. > > +R: Hervé Poussineau <hpous...@reactos.org> >>>>> >>>> >>>> I don't think Hervé is interested by this board, he has not modified the >>>> code. >>>> >>>> +R: Aleksandar Markovic <amarko...@wavecomp.com> >>>>> +S: Maintained >>>>> >>>> >>>> Let keep it as "Odd Fixes" :) >>>> >>>> >>> OK. >>> >>> Odd Fixes: It has a maintainer but they don't have >>>> time to do much other than throw the odd >>>> patch in. >>>> >>>> F: hw/mips/mips_fulong2e.c >>>>> F: hw/isa/vt82c686.c >>>>> F: hw/pci-host/bonito.c >>>>> >>>>> >>>> So the patch would be: >>>> >>>> -- 8< -- >>>> Fulong 2E >>>> -M: Aleksandar Markovic <amarko...@wavecomp.com> >>>> -R: Aleksandar Rikalo <aleksandar.rik...@rt-rk.com> >>>> +M: Philippe Mathieu-Daudé <f4...@amsat.org> >>>> +R: Aleksandar Markovic <amarko...@wavecomp.com> >>>> +R: Huacai Chen <che...@lemote.com> >>>> S: Odd Fixes >>>> F: hw/mips/mips_fulong2e.c >>>> F: hw/isa/vt82c686.c >>>> >>> >>> Plus possible s/Fulong 2E/Fuloong 2E/ >>> >> > I'd prefer to keep this change for later, with the patch cleaning its use > in the codebase (not that trivial because we need to alias the machine name > to keep backward compatibility). > > >>> --- >>>> >>>> But let's wait to see what Huacai Chen thinks of it, before posting it. >>>> >>> > Aleksandar, can you stay as co-maintainer? > > The patch would be: > > -- 8< -- > Fulong 2E > +M: Philippe Mathieu-Daudé <f4...@amsat.org> > M: Aleksandar Markovic <amarko...@wavecomp.com> > -R: Aleksandar Rikalo <aleksandar.rik...@rt-rk.com> > S: Odd Fixes > F: hw/mips/mips_fulong2e.c > F: hw/isa/vt82c686.c > --- > > OK, Philippe, all you said makes sense. Will update in v3. Not sure about my R or M. I'll see later. Hopefully Chen is going to join soon next year. Have a great weekend! Aleks. > Either this way, or if you prefer to be listed with a R-tag: > Acked-by: Philippe Mathieu-Daudé <f4...@amsat.org> > > >
