On commit abf0bf998dcb John Snow moved some code out of __init__.py to machine.py. kvm_available() remained in though. So on patch 01 I continue his work by creating a home for that method (the new 'accel' module). Honestly I was unsure about whether move the code to any existing module or make a new, but since I am adding more methods related with accelerators then I thought they would deserve a module.
The patches 02-04 introduce new helpers and make improvements. Later I intend to use those methods on the acceptance tests such as to automatically set the accelerator in QEMUMachine VM via Avocado tags, and skip the test if the accelerator is not available. Patch 05 just remove unneeded imports in __init__.py Changes v2 -> v3: - Refactor subprocess.check_output() call (patch 02) [crosa] Not using shell=True Pass universal_newlines=True so don't need to decode() the output Do not check if returned accelerator's name is empty string - New patch 05 [crosa] On patch 01 Cleber suggested to remove unneeded imports in python/qemu/__init__.py Changes v1 -> v2: - Removed 'Based on qmp.py' from python/qemu/accel.py (patch 01) [alex.bennee] - logging added only when used on python/qemu/accel.py (patch 02) [alex.bennee] Git: - Tree: https://github.com/wainersm/qemu - Branch: python_accel_v3 CI: - Travis (FAIL): https://travis-ci.org/wainersm/qemu/builds/623800273 Failure is not related with this change Wainer dos Santos Moschetta (5): python/qemu: Move kvm_available() to its own module python/qemu: accel: Add list_accel() method python/qemu: accel: Strengthen kvm_available() checks python/qemu: accel: Add tcg_available() method python/qemu: Remove unneeded imports in __init__ python/qemu/__init__.py | 24 ------------- python/qemu/accel.py | 77 +++++++++++++++++++++++++++++++++++++++++ tests/vm/basevm.py | 2 +- 3 files changed, 78 insertions(+), 25 deletions(-) create mode 100644 python/qemu/accel.py -- 2.21.0
