On 13/12/2019 13:00, Greg Kurz wrote: > It isn't used anymore. Fantastic !
> Signed-off-by: Greg Kurz <gr...@kaod.org> Reviewed-by: Cédric Le Goater <c...@kaod.org> Thanks, C. > --- > hw/ppc/pnv.c | 5 ----- > include/hw/ppc/pnv.h | 9 --------- > 2 files changed, 14 deletions(-) > > diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c > index cc40b90e9cd2..232b4a25603c 100644 > --- a/hw/ppc/pnv.c > +++ b/hw/ppc/pnv.c > @@ -1132,7 +1132,6 @@ static void pnv_chip_power8e_class_init(ObjectClass > *klass, void *data) > DeviceClass *dc = DEVICE_CLASS(klass); > PnvChipClass *k = PNV_CHIP_CLASS(klass); > > - k->chip_type = PNV_CHIP_POWER8E; > k->chip_cfam_id = 0x221ef04980000000ull; /* P8 Murano DD2.1 */ > k->cores_mask = POWER8E_CORE_MASK; > k->core_pir = pnv_chip_core_pir_p8; > @@ -1156,7 +1155,6 @@ static void pnv_chip_power8_class_init(ObjectClass > *klass, void *data) > DeviceClass *dc = DEVICE_CLASS(klass); > PnvChipClass *k = PNV_CHIP_CLASS(klass); > > - k->chip_type = PNV_CHIP_POWER8; > k->chip_cfam_id = 0x220ea04980000000ull; /* P8 Venice DD2.0 */ > k->cores_mask = POWER8_CORE_MASK; > k->core_pir = pnv_chip_core_pir_p8; > @@ -1180,7 +1178,6 @@ static void pnv_chip_power8nvl_class_init(ObjectClass > *klass, void *data) > DeviceClass *dc = DEVICE_CLASS(klass); > PnvChipClass *k = PNV_CHIP_CLASS(klass); > > - k->chip_type = PNV_CHIP_POWER8NVL; > k->chip_cfam_id = 0x120d304980000000ull; /* P8 Naples DD1.0 */ > k->cores_mask = POWER8_CORE_MASK; > k->core_pir = pnv_chip_core_pir_p8; > @@ -1360,7 +1357,6 @@ static void pnv_chip_power9_class_init(ObjectClass > *klass, void *data) > DeviceClass *dc = DEVICE_CLASS(klass); > PnvChipClass *k = PNV_CHIP_CLASS(klass); > > - k->chip_type = PNV_CHIP_POWER9; > k->chip_cfam_id = 0x220d104900008000ull; /* P9 Nimbus DD2.0 */ > k->cores_mask = POWER9_CORE_MASK; > k->core_pir = pnv_chip_core_pir_p9; > @@ -1449,7 +1445,6 @@ static void pnv_chip_power10_class_init(ObjectClass > *klass, void *data) > DeviceClass *dc = DEVICE_CLASS(klass); > PnvChipClass *k = PNV_CHIP_CLASS(klass); > > - k->chip_type = PNV_CHIP_POWER10; > k->chip_cfam_id = 0x120da04900008000ull; /* P10 DD1.0 (with NX) */ > k->cores_mask = POWER10_CORE_MASK; > k->core_pir = pnv_chip_core_pir_p10; > diff --git a/include/hw/ppc/pnv.h b/include/hw/ppc/pnv.h > index 4972e93c2619..f78fd0dd967c 100644 > --- a/include/hw/ppc/pnv.h > +++ b/include/hw/ppc/pnv.h > @@ -38,14 +38,6 @@ > #define PNV_CHIP_GET_CLASS(obj) \ > OBJECT_GET_CLASS(PnvChipClass, (obj), TYPE_PNV_CHIP) > > -typedef enum PnvChipType { > - PNV_CHIP_POWER8E, /* AKA Murano (default) */ > - PNV_CHIP_POWER8, /* AKA Venice */ > - PNV_CHIP_POWER8NVL, /* AKA Naples */ > - PNV_CHIP_POWER9, /* AKA Nimbus */ > - PNV_CHIP_POWER10, /* AKA TBD */ > -} PnvChipType; > - > typedef struct PnvChip { > /*< private >*/ > SysBusDevice parent_obj; > @@ -123,7 +115,6 @@ typedef struct PnvChipClass { > SysBusDeviceClass parent_class; > > /*< public >*/ > - PnvChipType chip_type; > uint64_t chip_cfam_id; > uint64_t cores_mask; > >