Hi Joakim,
I'm cc'ing the PPC maintainers for you, so they won't miss your patch
(see
https://wiki.qemu.org/Contribute/SubmitAPatch#CC_the_relevant_maintainer
and the output of ./scripts/get_maintainer.pl -f target/ppc/excp_helper.c).
On 12/14/19 1:13 PM, Joakim Tjernlund wrote:
From: Joakim Tjernlund <joakim.tjernl...@infinera.com>
ppc logs every type of Invalid instruction. This generates a lot
of garbage on console when sshd/ssh_keygen executes as
they try various insn to optimize its performance.
The invalid operation log is still there so an unknown insn
will still be logged.
Signed-off-by: Joakim Tjernlund <joakim.tjernl...@infinera.com>
---
As far as I can see, ppc is the only one emiting thsi
debug msg for Invalid insns.
target/ppc/excp_helper.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
index 50b004d00d..45c2fa3ff9 100644
--- a/target/ppc/excp_helper.c
+++ b/target/ppc/excp_helper.c
@@ -326,7 +326,6 @@ static inline void powerpc_excp(PowerPCCPU *cpu, int
excp_model, int excp)
env->spr[SPR_BOOKE_ESR] = ESR_FP;
break;
case POWERPC_EXCP_INVAL:
- LOG_EXCP("Invalid instruction at " TARGET_FMT_lx "\n", env->nip);
I don't think we want to remove a such important log. Since it make
sense to not disturb the console, maybe we can replace some of the
LOG_EXCP() calls by qemu_log_mask(LOG_GUEST_ERROR,...) instead?
msr |= 0x00080000;
env->spr[SPR_BOOKE_ESR] = ESR_PIL;
break;
