On (Fri) 03 Jun 2011 [16:03:59], Luiz Capitulino wrote:
>
> +static int media_insert(const char *device, const char *mediafile,
> + const char *format)
> +{
> + BlockDriver *drv = NULL;
> + BlockDriverState *bs;
> + int bdrv_flags;
> +
> + bs = bdrv_removable_find(device);
> + if (!bs) {
> + return -1;
> + }
> +
> + if (bdrv_is_locked(bs)) {
> + qerror_report(QERR_DEVICE_LOCKED, bdrv_get_device_name(bs));
> + return -1;
> + }
> +
> + if (bdrv_is_inserted(bs)) {
> + /* FIXME: will report undefined error in QMP */
> + return -1;
> + }
> +
> + if (!bs->tray_open) {
> + /* FIXME: will report undefined error in QMP */
> + return 1;
> + }
Yes, these should be fixed.
Amit
