Yes, of course (I thought it would be clear from the message, but perhaps it was a bit implicit).
Paolo Il lun 30 dic 2019, 16:48 Philippe Mathieu-Daudé <phi...@redhat.com> ha scritto: > On Mon, Dec 30, 2019 at 3:02 PM Philippe Mathieu-Daudé > <phi...@redhat.com> wrote: > > On 12/30/19 11:33 AM, Paolo Bonzini wrote: > > > Il lun 30 dic 2019, 09:59 Philippe Mathieu-Daudé <phi...@redhat.com > > > <mailto:phi...@redhat.com>> ha scritto: > > > > > > > I'd prefer not changing those files. > > > > > > OK, I'll wait to see what Richard/Markus prefer. > > > > > > > > > I think it's best if you keep the include directives as-is for files > > > only needed from tcg/, and move the other headers (those that are > needed > > > from other directories only) to include/tcg. > > Assuming we don't want to add include/tcg/ in the path search list, we > still need to update the tcg/*.c include directives to use "tcg/": > > tcg/tcg-op-gvec.c:21:10: fatal error: tcg.h: No such file or directory > 21 | #include "tcg.h" > | ^~~~~~~ > compilation terminated. > make[1]: *** [rules.mak:69: tcg/tcg-op-gvec.o] Error 1 > make[1]: *** Waiting for unfinished jobs.... > CC mips64el-softmmu/accel/tcg/translate-all.o > tcg/optimize.c:27:10: fatal error: tcg-op.h: No such file or directory > 27 | #include "tcg-op.h" > | ^~~~~~~~~~ > compilation terminated. > make[1]: *** [rules.mak:69: tcg/optimize.o] Error 1 > tcg/tcg-op-vec.c:22:10: fatal error: tcg.h: No such file or directory > 22 | #include "tcg.h" > | ^~~~~~~ > compilation terminated. > make[1]: *** [rules.mak:69: tcg/tcg-op-vec.o] Error 1 > tcg/tcg-common.c:35:10: fatal error: tcg-opc.h: No such file or directory > 35 | #include "tcg-opc.h" > | ^~~~~~~~~~~ > compilation terminated. > make[1]: *** [rules.mak:69: tcg/tcg-common.o] Error 1 > tcg/tcg-op.c:28:10: fatal error: tcg.h: No such file or directory > 28 | #include "tcg.h" > | ^~~~~~~ > compilation terminated. > make[1]: *** [rules.mak:69: tcg/tcg-op.o] Error 1 > tcg/tcg.c:51:10: fatal error: tcg-op.h: No such file or directory > 51 | #include "tcg-op.h" > | ^~~~~~~~~~ > compilation terminated. > > > I thought moving headers to include/tcg would diverge too much from > > libtcg, but this project already did it, so why not: > > https://github.com/S2E/libtcg/tree/master/include/tcg > >
