On 2011-06-08 16:33, Peter Maydell wrote: > On 8 June 2011 15:10, Jan Kiszka <jan.kis...@siemens.com> wrote: >> --- /dev/null >> +++ b/scripts/update-linux-headers.sh >> @@ -0,0 +1,55 @@ >> +#!/bin/sh -e >> +# > >> +if [ -z "$output" ]; then >> + output=$PWD >> +fi > >> + mkdir -p $output/linux-headers/asm-$arch > > This script is rather lacking in quoting throughout. As a random > example, this looks like it will break if you run the script from > a directory with a space in the path.
True. > >> +tmpdir=$TMPDIR/.tmp-hdrs-$$ > > Better (safer) to use mktemp, I think. Is that portable? I don't think so. > >> if [ -z "$linux" -o ! -d "$linux" ]; then > > test -o is obsolescent in POSIX; use > if [ -z "$linux" ] || ! [ -d "$linux" ] ; then > instead. > OK. Thanks, Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux
