On Thu, Jan 09, 2020 at 08:13:38AM +0100, Cédric Le Goater wrote: > >>>> void helper_book3s_msgclr(CPUPPCState *env, target_ulong rb) > >>>> { > >>>> - int irq = book3s_dbell2irq(rb); > >>>> + int irq = book3s_dbell2irq(rb, 1); > >>> > >>> true/false are preferred to 0/1 for bool types. > >> > >> yes or a define ? > > > > Sorry, I don't understand the question. The second argument to > > book3s_dbell2irq() is a 'bool' type, so the parameter should be 'true' > > rather than '1'. > > Yes. I was thinking of adding defines for the 'true' and 'false' value > to clarify what the parameter is doing. But it does not seem really > useful now.
You don't need your own defines, they already exist. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature